Func on mani #8
Merged
Func on mani #8
+1,206
−692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdarricau
force-pushed
the
funcOnMani
branch
2 times, most recently
from
b7daad8 to
bec55f7
Compare
| long mappingFromFunctionSize_; | ||
|
|
||
| /// \brief array representing the restricted mapping for the tangent problem | ||
| size_t* tangentMappingFromFunction_; |
There was a problem hiding this comment.
Why not use a std::vector<size_t> for mappingFromFunction_ and tangentMappingFromFunction_?
There was a problem hiding this comment.
Those are fixed-size arrays whose size will be known at runtime, so maybe we could use std::array, but a std::vector is not necessary here.
There was a problem hiding this comment.
I would simply advise against using C-style arrays with new/delete when we could use the STL, unless there is a good reason for that.
Delca
added a commit
that referenced
this pull request
Jun 2, 2015
Interfacing the FunctionOnManifold implementation, to let it support virtually every RobOptim's Function type, and thus supporting (for instance) hessian computing on manifolds, which wasn't supported before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfacing the FunctionOnManifold implementation, to let it support virtually every RobOptim's Function type, and thus supporting for instance hessian computing on manifolds, which wasn't supported before.