Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for upload binary data via cpp bindings #696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for upload binary data via cpp bindings #696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/elliptics/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,10 +342,15 @@ class argument_data_base
}

argument_data_base(const char *data) :
m_data(pointer_type::from_raw(const_cast<char *>(data), std::strlen(data)))
m_data(pointer_type::from_raw(const_cast<char *>(data), std::strlen(data))) // It isn't correct for binary data.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// It isn't correct for binary data.

This comment is unnecessary as the constructor is not about binary data.

{
}

argument_data_base(const char *data, size_t size) :
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should use here const void *data to explicitly specify that the constructor is for binary data.

m_data(pointer_type::from_raw(const_cast<char *>(data), size))
{
}

const void *data() const
{
return m_data.data();
Expand Down