Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): implement "set -a" #336

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat(options): implement "set -a" #336

merged 1 commit into from
Jan 20, 2025

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Jan 20, 2025

No description provided.

Copy link

github-actions bot commented Jan 20, 2025

Test Results

    2 files      9 suites   1m 21s ⏱️
  601 tests   601 ✅ 0 💤 0 ❌
1 188 runs  1 188 ✅ 0 💤 0 ❌

Results for commit 717bf9a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 20, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 16.51 μs 16.32 μs -0.18 μs 🟢 -1.11%
eval_arithmetic 0.20 μs 0.19 μs -0.01 μs ⚪ Unchanged
expand_one_string 1.60 μs 1.59 μs -0.01 μs ⚪ Unchanged
for_loop 32.94 μs 32.88 μs -0.05 μs ⚪ Unchanged
function_call 3.44 μs 3.61 μs 0.17 μs ⚪ Unchanged
instantiate_shell 48.21 μs 48.53 μs 0.32 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 24188.83 μs 23405.39 μs -783.44 μs 🟢 -3.24%
parse_bash_completion 1667.41 μs 1663.95 μs -3.46 μs ⚪ Unchanged
parse_sample_script 1.76 μs 1.75 μs -0.01 μs ⚪ Unchanged
run_echo_builtin_command 16.57 μs 16.13 μs -0.44 μs ⚪ Unchanged
run_one_external_command 2453.51 μs 2345.12 μs -108.39 μs 🟢 -4.42%
tokenize_sample_script 2.78 μs 2.87 μs 0.09 μs 🟠 +3.31%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/declare.rs 🟢 81.79% 🟢 81.94% 🟢 0.15%
brush-core/src/env.rs 🟢 88.05% 🟢 87.45% 🔴 -0.6%
brush-core/src/interp.rs 🟢 90.91% 🟢 91.08% 🟢 0.17%
brush-core/src/shell.rs 🟢 77.95% 🟢 78.08% 🟢 0.13%
brush-core/src/variables.rs 🟢 80.04% 🟢 80.9% 🟢 0.86%
Overall Coverage 🟢 74.68% 🟢 74.74% 🟢 0.06%

Minimum allowed coverage is 70%, this run produced 74.74%

@reubeno reubeno merged commit 2e2a354 into main Jan 20, 2025
17 checks passed
@reubeno reubeno deleted the set-a branch January 20, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant