Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement date and time in prompts #298

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix: implement date and time in prompts #298

merged 1 commit into from
Dec 26, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Dec 26, 2024

Fills out implementation and adds tests for the follow escape sequences in prompt strings:

  • \d
  • \D
  • \t
  • \T
  • \@

Copy link

github-actions bot commented Dec 26, 2024

Test Results

    2 files      9 suites   1m 14s ⏱️
  564 tests   564 ✅ 0 💤 0 ❌
1 114 runs  1 114 ✅ 0 💤 0 ❌

Results for commit 1582640.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 26, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.51 μs 3.51 μs 0.00 μs ⚪ Unchanged
instantiate_shell 62.22 μs 62.30 μs 0.08 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 28564.83 μs 28420.24 μs -144.59 μs ⚪ Unchanged
parse_bash_completion 2867.59 μs 2824.63 μs -42.97 μs 🟢 -1.50%
parse_sample_script 4.45 μs 4.38 μs -0.07 μs ⚪ Unchanged
run_echo_builtin_command 92.27 μs 92.14 μs -0.13 μs ⚪ Unchanged
run_one_builtin_command 113.40 μs 110.92 μs -2.48 μs ⚪ Unchanged
run_one_external_command 1757.49 μs 1751.26 μs -6.23 μs ⚪ Unchanged
run_one_external_command_directly 823.80 μs 823.36 μs -0.45 μs ⚪ Unchanged

Benchmarks added:

  • for_loop

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/jobs.rs 🔴 42.42% 🔴 37.23% 🔴 -5.19%
brush-core/src/prompt.rs 🟢 77.92% 🟢 90.38% 🟢 12.46%
brush-core/src/sys/unix/signal.rs 🟠 67.92% 🟠 71.7% 🟢 3.78%
Overall Coverage 🟢 77.12% 🟢 77.19% 🟢 0.07%

Minimum allowed coverage is 70%, this run produced 77.19%

@reubeno reubeno marked this pull request as ready for review December 26, 2024 07:04
@reubeno reubeno merged commit eacb489 into main Dec 26, 2024
17 checks passed
@reubeno reubeno deleted the prompt-dates branch December 26, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant