Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin workflows to specific ubuntu versions #293

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Dec 16, 2024

ubuntu-latest is going to get upgraded to ubuntu-24.04 shortly, but we'd rather intentionally upgrade and work through any issues rather than having them "show up one day".

This PR pins all workflows toubuntu-24.04 with the one notable exception of the native x86_64/Linux build, which we pin to ubuntu-22.04. We do this intentionally because 24.04 brings in a newer version of glibc and decreased compatibility for produced rust binaries.

Copy link

github-actions bot commented Dec 16, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.52 μs 3.52 μs -0.00 μs ⚪ Unchanged
instantiate_shell 62.31 μs 62.89 μs 0.58 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 28549.33 μs 28844.84 μs 295.51 μs ⚪ Unchanged
parse_bash_completion 2801.31 μs 2775.80 μs -25.52 μs 🟢 -0.91%
parse_sample_script 4.25 μs 4.30 μs 0.05 μs ⚪ Unchanged
run_echo_builtin_command 91.59 μs 91.86 μs 0.27 μs ⚪ Unchanged
run_one_builtin_command 111.89 μs 110.23 μs -1.67 μs ⚪ Unchanged
run_one_external_command 1787.77 μs 1802.70 μs 14.93 μs ⚪ Unchanged
run_one_external_command_directly 826.47 μs 824.76 μs -1.70 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 74.67% 🟢 74.67% ⚪ 0%

Minimum allowed coverage is 70%, this run produced 74.67%

Copy link

github-actions bot commented Dec 16, 2024

Test Results

    2 files      9 suites   1m 14s ⏱️
  556 tests   556 ✅ 0 💤 0 ❌
1 098 runs  1 098 ✅ 0 💤 0 ❌

Results for commit 6c8939f.

♻️ This comment has been updated with latest results.

@reubeno reubeno changed the title chore: upgrade workflows to use ubuntu-24.04 chore: pin workflows to specific ubuntu versions Dec 16, 2024
@reubeno reubeno marked this pull request as ready for review December 16, 2024 05:08
@reubeno reubeno requested a review from Copilot December 16, 2024 05:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@reubeno reubeno merged commit 035ef83 into main Dec 16, 2024
17 checks passed
@reubeno reubeno deleted the upgrade-runners branch December 16, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant