Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for jobs, backquotes, and builtins #14

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented May 17, 2024

No description provided.

@reubeno reubeno enabled auto-merge (squash) May 17, 2024 04:16
@reubeno reubeno merged commit 1277ff0 into main May 17, 2024
4 checks passed
Copy link

Test Results

358 tests   341 ✅  2m 24s ⏱️
 59 suites   17 💤
  8 files      0 ❌

Results for commit 3188b13.

Copy link

Performance Benchmark Report

Benchmark name Baseline (ns) Test/PR (ns) Delta (ns) Delta %
expand_one_string 3312 ns 3357 ns +45 ns 🟠 +1.36%
instantiate_shell 52523 ns 65032 ns +12509 ns 🟠 +23.82%
instantiate_shell_with_init_scripts 48391946 ns 48235729 ns -156217 ns 🟢 -0.32%
parse_bash_completion 6629899 ns 6623015 ns -6884 ns 🟢 -0.10%
parse_sample_script 11014 ns 10896 ns -118 ns 🟢 -1.07%
run_echo_builtin_command 91276 ns 104099 ns +12823 ns 🟠 +14.05%
run_one_builtin_command 108672 ns 121407 ns +12735 ns 🟠 +11.72%
run_one_external_command 1796791 ns 1835663 ns +38872 ns 🟠 +2.16%
run_one_external_command_directly 1034800 ns 1040279 ns +5479 ns 🟠 +0.53%

Code Coverage Report

Package Base Coverage New Coverage Difference
cli.src 🟠 73.95% 🟠 73.95% ⚪ 0%
interactive-shell.src 🟢 75.88% 🟢 76.02% 🟢 0.14%
parser.src 🟢 85.86% 🟢 85.88% 🟢 0.02%
shell.src 🟢 80.58% 🟢 81.32% 🟢 0.74%
shell.src.builtins 🟠 67.57% 🟠 69.06% 🟢 1.49%
Overall Coverage 🟢 79.09% 🟢 79.67% 🟢 0.58%

Minimum allowed coverage is 0%, this run produced 79.67%

@reubeno reubeno deleted the more-more-more branch May 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant