-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Packagist proxy through HTTP Proxy #646
base: master
Are you sure you want to change the base?
Conversation
…context as this method already support HTTP proxy settings [repman-http-proxy]
621bec4
to
1e7caef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
=========================================
Coverage 99.03% 99.03%
Complexity 1916 1916
=========================================
Files 301 301
Lines 6083 6083
=========================================
Hits 6024 6024
Misses 59 59 ☔ View full report in Codecov by Sentry. |
Can we add test for that or it will be too complicated? |
I could unit test method createContext with fake URL and multiple proxy/no_proxy settings to make sure options returned to create a context are what we expect. |
Works for me, at least test will concrete solution 😅 |
Should be good now, I've done some tests to verify stream context on multiple case:
|
…e tests to check that stream context is correctly built when using http proxy [repman-http-proxy]
0ecbb27
to
8d05acd
Compare
Use StreamContextFactory from composer package to create stream context as this method already support HTTP proxy settings