Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an active state to the side navigation #305

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

sardorml
Copy link
Contributor

@sardorml sardorml commented Nov 2, 2024

Added an active state to the side navigation heading based on user scroll.

@sardorml
Copy link
Contributor Author

sardorml commented Nov 2, 2024

Screen.Recording.2024-11-02.at.2.30.06.PM.mp4

@sardorml
Copy link
Contributor Author

sardorml commented Nov 2, 2024

Hey @brookslybrand, added it here as well.

@brookslybrand brookslybrand self-requested a review November 4, 2024 13:48
Copy link
Contributor

@brookslybrand brookslybrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you @sardorml 🙏

@brookslybrand brookslybrand merged commit dff2f62 into remix-run:main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants