Adding a blog post about React Router brand updates #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A written record of the design thinking and process, with technical diagrams and examples of how to use the new brand identity.
mjackson
reviewed
Oct 29, 2024
mjackson
approved these changes
Oct 29, 2024
Co-authored-by: Michael Jackson <[email protected]>
brookslybrand
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
So good! This was a lovely read, and really shows that you "get it". Happy to have you on the team :)
I think folks are really gonna like this. I left a few comments on specific questions. Here are two more high-level ones:
- I would add
mx-8to all of the images. I'm not sure why we don't have a default images set, but without this there's no spacing between the images that are stacked on top of each other without any paragraphs in between. - Personally I don't know how I feel about the
w-4/5for the images. However, if you want to keep it, I'd recommend changing it tosm:w-4/5, that way on mobile it's the width of the text and therefore a little easier to see
Happy to deploy this on staging tomorrow so we can take a final look at the production version before deploying
Co-authored-by: Brooks Lybrand <[email protected]>
Co-authored-by: Brooks Lybrand <[email protected]>
…emix-website into blog-rr-brand-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A written record of the design thinking and process, with technical diagrams and examples of how to use the updated brand identity.