Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerender SPA mode bug report test #12689

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

namoscato
Copy link

The Single Page App (SPA) guide notes pre-rendering can be configured, but a build-time error is always thrown when a route loader is defined in SPA mode (ssr: false):

[react-router:route-exports] SPA Mode: 1 invalid route export(s) in `routes/home.tsx`: `loader`. See https://remix.run/guides/spa-mode for more information.

Am I misunderstanding SPA pre-rendering?

Copy link

changeset-bot bot commented Jan 4, 2025

⚠️ No Changeset found

Latest commit: b484311

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 4, 2025

Hi @namoscato,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 4, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@amydevs
Copy link

amydevs commented Jan 6, 2025

IMO i would like for loaders to be allowed for when prerendering + spa are both enabled for a similar purpose as next.js' getStaticProps. However, I believe loaders are currently intentionally disabled in SPA mode entirely, as SPA mode without prerendering does not allow for SSG features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants