Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): resolve optimizeDeps entries properly on Windows #12637

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

wKovacs64
Copy link

TL;DR - unstable_optimizeDeps doesn't work well on Windows due to path resolution issues. This fixes it. All credit goes to @sebastien-comeau for remix-run/remix#10258 (which still needs merged for the Windows folks still on Remix v2, btw).

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: a3ea46b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 24, 2024

Hi @wKovacs64,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 24, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@sebastien-comeau
Copy link

@wKovacs64 Merging is blocked

Merge is not an allowed merge method in this repository.

🤷

@pcattori pcattori self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants