fix(perf): remove DOM mutation overhead from fog-of-war prefetch #12542
Conversation
In a real-world website I am testing this against, this reduces the fog-of-war's blocking JS during SPA transitions from 100ms to 1.2ms.
|
|
Hi @developit, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
| // optimization: use the already-parsed pathname from links | ||
| let pathname = | ||
| el.tagName === 'A' | ||
| ? (el as HTMLAnchorElement).pathname |
There was a problem hiding this comment.
It almost certainly doesn't matter, but <area> also has these helpers
There was a problem hiding this comment.
this only runs on <a> and <form> (I assume because remix doesn't support other types of links?)
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
In a real-world website I am testing this against, this reduces the fog-of-war's blocking JS during SPA transitions from 100ms to 1.2ms.