Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support moduleResolution Node16 and NodeNext for non-JS files. #12453

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nowells
Copy link

@nowells nowells commented Dec 3, 2024

#12440 introduced a fix for tsconfig, however, it broke non-JS routes (like .mdx)

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: f21c90c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 3, 2024

Hi @nowells,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 3, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@nowells nowells force-pushed the nstrite/typescript-non-js branch from 79de206 to 07c5077 Compare December 3, 2024 17:22
remix-run#12440 introduced a fix for tsconfig, however, it broke non-JS routes (like .mdx)
@nowells
Copy link
Author

nowells commented Jan 8, 2025

I have worked around this with patch-package locally, however, I think this will bite many people who use mdx in their sites, which I think is rather common, so hoping we can land this before too many people take a swing at adopting v7 (which has been a very smooth upgrade from remix!)

@timdorr timdorr requested a review from pcattori January 8, 2025 16:00
@pcattori pcattori self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants