Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename server.js file to server.mjs #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aarbi
Copy link

@aarbi aarbi commented Dec 8, 2024

This is already referenced in tsconfig.node.json here
also the current node LTS version supports running .mjs scripts

aarbi added 2 commits December 8, 2024 15:06
this is also referenced in tsconfig.node.json
@brookslybrand
Copy link
Contributor

@aarbi can you help me understand the benefit here?

I'm definitely with you that the tsconfig.node.json file should match whatever is being used, but not sure the advantage of merging this otherwise

@aarbi
Copy link
Author

aarbi commented Dec 9, 2024

Either ways are fine with me too.
server.js is syntactically a valid .mjs file. We also have type = module in package.json. So just so everything would esm compatible.
Otherwise I can update this PR to only update the tsconfig file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants