Add Prereq section to Testing page #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am trying to keep Python2 compatibility even for the tests - https://travis-ci.com/refack/GYP/jobs/181771177 P.S. The docs do seems a bit dated in other respects as well :SMH: |
refack
requested changes
Mar 5, 2019
| @@ -20,6 +20,14 @@ could be completely written to add a feature or fix a bug | |||
| so long as they continue to support the functional behaviors | |||
| defined by the tests: building programs, shared libraries, etc. | |||
|
|
|||
| ## Prerequisites | |||
|
|
|||
| * Python 3 in the path | |||
There was a problem hiding this comment.
Suggested change
| * Python 3 in the path | |
| * Python 3 (or 2) in the path | |
| * Tests should pass on both Python3.7 and Python2.7 |
| ## Prerequisites | ||
|
|
||
| * Python 3 in the path | ||
| * Using python 2 causes "only strings in environment" errors |
There was a problem hiding this comment.
Suggested change
| * Using python 2 causes "only strings in environment" errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From just trying to run them, the tests seem to be Python-3-only, so I added this fact to the Testing page.
I have only confirmed the part about the test telling you if something is missing with MSVC.