Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] migrate to ruff linter fix b024 - 0/n #50001

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simotw
Copy link

@simotw simotw commented Jan 22, 2025

Why are these changes needed?

according to the abstract-base-class-without-abstract-method rule

Abstract base classes are used to define interfaces. If an abstract base class has no abstract methods or properties, you may have forgotten to add an abstract method or property to the class, or omitted an @AbstractMethod decorator.

If the class is not meant to be used as an interface, consider removing the ABC base class from the class definition.

Related PR

#49917

Related issue number

#47991

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simotw simotw changed the title [Refactor] migrate to ruff linter fix b024 - 0 [Refactor] migrate to ruff linter fix b024 - 0/n Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant