Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semi-Random Weighting to AutoScaler Node Scheduler #49983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fogerd
Copy link

@fogerd fogerd commented Jan 21, 2025

Why are these changes needed?

When trying to utilize spot instance types, we noticed the Autoscaler would get stuck attempting to scale up a node type with no availability and never recover / move on to try other node types. This change introduces some randomness, with weighting, so that the Autoscaler will try different node types on each loop and prevent the described scenario.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fogerd fogerd requested review from hongchaodeng and a team as code owners January 21, 2025 15:48
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants