Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Fix bug where file_extensions doesn't work with compound extensions #49244

Merged
merged 20 commits into from
Jan 2, 2025
Merged

[Data] Fix bug where file_extensions doesn't work with compound extensions #49244

merged 20 commits into from
Jan 2, 2025

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

If you specify file_extensions=["parquet"] in a read API, Ray Data accepts files that end with .parquet.crc, even though you probably want to exclude them. This PR fixes that issue.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
cb830b0 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
1d9dd2e 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
bed2558 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
c40b06d 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
49a8d71 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
cad41d5 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
17df280 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
bb0e778 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
2620239 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
4dff29a 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Initial commit
20e8ee4 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani requested a review from a team as a code owner December 13, 2024 00:30
@bveeramani bveeramani enabled auto-merge (squash) December 13, 2024 17:56
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 13, 2024
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
0393f97 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
2a92d8e 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
7d912a8 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
e38bf85 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
01c8911 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
a7e6cb2 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Merge branch 'master' into file-extensions
8c1ff22 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Fix bug
c5972eb 
Signed-off-by: Balaji Veeramani <[email protected]>
@github-actions github-actions bot disabled auto-merge January 2, 2025 20:53
@bveeramani
Fix bug
d641f5d 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani merged commit aece8c0 into master Jan 2, 2025
5 checks passed
@bveeramani bveeramani deleted the file-extensions branch January 2, 2025 23:57
roshankathawate pushed a commit to roshankathawate/ray that referenced this pull request Jan 7, 2025
@bveeramani
[Data] Fix bug where file_extensions doesn't work with compound ext…
19c79e0 
…ensions (ray-project#49244)

If you specify `file_extensions=["parquet"]` in a read API, Ray Data
accepts files that end with `.parquet.crc`, even though you probably
want to exclude them. This PR fixes that issue.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
roshankathawate pushed a commit to roshankathawate/ray that referenced this pull request Jan 9, 2025
@bveeramani @roshankathawate
[Data] Fix bug where file_extensions doesn't work with compound ext…
66f97e8 
…ensions (ray-project#49244)

If you specify `file_extensions=["parquet"]` in a read API, Ray Data
accepts files that end with `.parquet.crc`, even though you probably
want to exclude them. This PR fixes that issue.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Roshan Kathawate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykudinkin alexeykudinkin alexeykudinkin approved these changes

Assignees

@alexeykudinkin alexeykudinkin

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bveeramani @alexeykudinkin