[Core] Fix bug to support S3 pre-signed url for .whl file #48560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey(Xilang) Yan <[email protected]>
yantzu
changed the title
yantzu
changed the title
Signed-off-by: Jeffrey(Xilang) Yan <[email protected]>
dentiny
approved these changes
Dec 12, 2024
|
@jjyao for approval and merge. |
|
Hi @jjyao ,the original build test failed, so I updated code to trigger another build, unluckily it still failed, but the failure should not related to this code changes, could you please take a look? orignal test link https://buildkite.com/ray-project/premerge/builds/31991 |
|
Hi, @jjyao the tests failed on different part each time,see |
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
…t#48560) Signed-off-by: Jeffrey(Xilang) Yan <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We meet error if we use a pre-signed S3 .whl file url as runtime env py-modules.
It turns out that it is a bug of Ray, current Ray doesn't support any .whl file url that has params, query or fragment part. Because ray will change the file name to a non-standard one then pip install will fail.
This PR is to fix the issue.
Related issue number
None
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.