updated optuna_search to allow users to configure optuna storage #48547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Dalal <[email protected]>
ravi-dalal
requested review from
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen and
woshiyyya
as code owners
Signed-off-by: Ravi Dalal <[email protected]>
Signed-off-by: Ravi Dalal <[email protected]>
Signed-off-by: Ravi Dalal <[email protected]>
|
@hongpeng-guo @justinvyu @matthewdeng @raulchen @woshiyyya could you please take a look at this PR? |
hongpeng-guo
reviewed
Nov 6, 2024
hongpeng-guo
reviewed
Nov 6, 2024
hongpeng-guo
reviewed
Nov 6, 2024
hongpeng-guo
reviewed
Nov 6, 2024
There was a problem hiding this comment.
@ravi-dalal Thanks for contributing to the ray project! Left a few comments. One question that I have is on the study_name argument, please elaborate more why this arg is necessary to be here with the storage.
Signed-off-by: Ravi Dalal <[email protected]>
Signed-off-by: Ravi Dalal <[email protected]>
|
@hongpeng-guo Thank you for taking time to review this PR. I updated the PR following your comments. PTAL when you get time. |
hongpeng-guo
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
@ravi-dalal Thanks for your contribution! PR LGTM.
cc @matthewdeng for one more pass before merge this PR.
matthewdeng
reviewed
Dec 6, 2024
python/requirements_compiled.txt
Outdated
| @@ -1519,7 +1516,7 @@ py-cpuinfo==9.0.0 | |||
| # via deepspeed | |||
| py-partiql-parser==0.5.0 | |||
| # via moto | |||
| py-spy==0.4.0 ; python_version < "3.12" | |||
| py-spy==0.3.14 | |||
There was a problem hiding this comment.
@hongpeng-guo I think we need to rebase/pull in the latest compiled dependencies here. This was modified in 73a4c42
hongpeng-guo
added
go
matthewdeng
approved these changes
Dec 9, 2024
justinvyu
requested changes
Dec 9, 2024
Comment on lines
381
to
382
| else: | ||
| self._storage = ot.storages.InMemoryStorage() |
There was a problem hiding this comment.
InMemoryStorage only exists in Optuna 4.x. Let's just pass in None, which works for both 3.x and 4.x:
There was a problem hiding this comment.
Good catch! Let me quickly fix it.
Signed-off-by: Hongpeng Guo <[email protected]>
…/tune/optuna_fix
justinvyu
approved these changes
Dec 10, 2024
Co-authored-by: Justin Yu <[email protected]> Signed-off-by: Hongpeng Guo <[email protected]>
Co-authored-by: Justin Yu <[email protected]> Signed-off-by: Hongpeng Guo <[email protected]>
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Dec 12, 2024
ray-project#48547) The OptunaSearch currently uses in-memory storage and does not provide a way to configure any other storages (e.g. database). This update add a configurable parameter to OptunaSearch that can be set to a valid Optuna Storage. Signed-off-by: Ravi Dalal <[email protected]> Signed-off-by: Ravi Dalal <[email protected]> Signed-off-by: Hongpeng Guo <[email protected]> Co-authored-by: Hongpeng Guo <[email protected]> Co-authored-by: matthewdeng <[email protected]> Co-authored-by: Hongpeng Guo <[email protected]> Co-authored-by: Justin Yu <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
ray-project#48547) The OptunaSearch currently uses in-memory storage and does not provide a way to configure any other storages (e.g. database). This update add a configurable parameter to OptunaSearch that can be set to a valid Optuna Storage. Signed-off-by: Ravi Dalal <[email protected]> Signed-off-by: Ravi Dalal <[email protected]> Signed-off-by: Hongpeng Guo <[email protected]> Co-authored-by: Hongpeng Guo <[email protected]> Co-authored-by: matthewdeng <[email protected]> Co-authored-by: Hongpeng Guo <[email protected]> Co-authored-by: Justin Yu <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The OptunaSearch currently uses in-memory storage and does not provide a way to configure any other storages (e.g. database). This update add a configurable parameter to OptunaSearch that can be set to a valid Optuna Storage.
Related issue number
Closes #48500
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.