Skip to content

Commit

Permalink
revert to max_inflight buffered channels
Browse files Browse the repository at this point in the history
Signed-off-by: dayshah <[email protected]>
  • Loading branch information
dayshah committed Jan 16, 2025
1 parent 0022380 commit f78c82c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion python/ray/dag/compiled_dag_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ def __init__(
# We conservatively set num_shm_buffers to _max_inflight_executions.
# It means that the DAG can be underutilized, but it guarantees there's
# no false positive timeouts.
num_shm_buffers=1,
num_shm_buffers=self._max_inflight_executions,
)
if not isinstance(self._buffer_size_bytes, int) or self._buffer_size_bytes <= 0:
raise ValueError(
Expand Down
1 change: 0 additions & 1 deletion python/ray/dag/tests/experimental/test_accelerated_dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -2343,7 +2343,6 @@ def test_driver_and_intraprocess_read(ray_start_cluster):
assert ray.get(dag.execute(1)) == [1, 2]


@pytest.mark.skip("Currently buffer size is set to 1 because of regression.")
@pytest.mark.parametrize("temporary_change_timeout", [1], indirect=True)
def test_buffered_inputs(shutdown_only, temporary_change_timeout):
ray.init()
Expand Down

0 comments on commit f78c82c

Please sign in to comment.