DRM fixes #5716
Merged
DRM fixes #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is permitted for a plane to be configured such that none of it is on-screen via either negative dest rectangle X,Y offset, or just an offset that is greater than the crtc dimensions. These planes were resized via drm_atomic_helper_check_plane_state such that the source rectangle had a zero width or height, but they still created a dlist entry even though they contributed no pixels. In the case of vc6_plane_mode_set, that it could result in negative values being written into registers, which caused incorrect behaviour. Drop planes that result in a source width or height of 0 pixels to avoid the incorrect rendering. Signed-off-by: Dave Stevenson <[email protected]>
Commit 7cd7065 ("drm/bridge: display-connector: implement bus fmts callbacks") added use of drm_atomic_helper_bridge_* functions, but didn't select the dependency of DRM_KMS_HELPER. If nothing else selected that dependency it resulted in a build failure. Select the missing dependency. Fixes: 7cd7065 ("drm/bridge: display-connector: implement bus fmts callbacks") Signed-off-by: Dave Stevenson <[email protected]>
|
Any objections to these? |
|
LGTM. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 23, 2023
…OGUE_GAIN See: raspberrypi/linux#5711 kernel: DRM fixes See: raspberrypi/linux#5716 kernel: drm: vc4: Free the dlist alloc immediately if it never hit the hw See: raspberrypi/linux#5733 kernel: Include I2C bus details in ft5x06 and goodix touch driver names See: raspberrypi/linux#5703 kernel: drm: vc4: Block swiotlb bounce buffers being imported as dmabuf See: raspberrypi/linux#5734
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 23, 2023
…OGUE_GAIN See: raspberrypi/linux#5711 kernel: DRM fixes See: raspberrypi/linux#5716 kernel: drm: vc4: Free the dlist alloc immediately if it never hit the hw See: raspberrypi/linux#5733 kernel: Include I2C bus details in ft5x06 and goodix touch driver names See: raspberrypi/linux#5703 kernel: drm: vc4: Block swiotlb bounce buffers being imported as dmabuf See: raspberrypi/linux#5734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off-screen planes is the image corruption reported in https://forums.raspberrypi.com/viewtopic.php?t=359396.
display-connector is #5715. I need to send it upstream, but seeing as I was creating a DRM PR I thought I'd stick it in here now.