Include I2C bus details in ft5x06 and goodix touch driver names #5703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pi1-4, as Pi0 doesn't have a DSI connector 😉 |
libinput uses the input device name alone. If you have two identical input devices, then there is no way to differentiate between them, and in the case of touchscreens that means no way to associate them with the appropriate display device. Add the I2C bus and address to the start of the input device name so that the name is always unique within the system. Signed-off-by: Dave Stevenson <[email protected]>
libinput uses the input device name alone. If you have two identical input devices, then there is no way to differentiate between them, and in the case of touchscreens that means no way to associate them with the appropriate display device. Add the I2C bus and address to the start of the input device name so that the name is always unique within the system. Signed-off-by: Dave Stevenson <[email protected]>
6by9
force-pushed
the
rpi-6.1.y-touchscreens
branch
from
f2efc75 to
b915a85
Compare
|
Simon has made the relevant ini file changes, so this is ready for review and merge. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 23, 2023
…OGUE_GAIN See: raspberrypi/linux#5711 kernel: DRM fixes See: raspberrypi/linux#5716 kernel: drm: vc4: Free the dlist alloc immediately if it never hit the hw See: raspberrypi/linux#5733 kernel: Include I2C bus details in ft5x06 and goodix touch driver names See: raspberrypi/linux#5703 kernel: drm: vc4: Block swiotlb bounce buffers being imported as dmabuf See: raspberrypi/linux#5734
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 23, 2023
…OGUE_GAIN See: raspberrypi/linux#5711 kernel: DRM fixes See: raspberrypi/linux#5716 kernel: drm: vc4: Free the dlist alloc immediately if it never hit the hw See: raspberrypi/linux#5733 kernel: Include I2C bus details in ft5x06 and goodix touch driver names See: raspberrypi/linux#5703 kernel: drm: vc4: Block swiotlb bounce buffers being imported as dmabuf See: raspberrypi/linux#5734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raspberrypi/bookworm-feedback#138
The name is only taken as a
const char *, so there's no easy way for the framework to do this munge.Adds the I2C bus number and address to the name, so DSI-2 wants to be associated with
4-0038 generic ft5x06 (79), and DSI-1 with6-0038 generic ft5x06 (79)for Pi5, and10-0038 generic ft5x06 (79)with DSI-1 on Pi0-4.Goodix is used by the HyperPixel and a few other displays, hence converted that one too.
Needs the relevant wayfire.ini updates before merging / releasing, hence draft for now.