Update Pool from Future to Concurrent::Promises #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on this one, @hms! With the holidays and being on-call, I haven't had time to look into this, but I'm going to run it for a bit in our app in production from today, before merging it. |
|
Oops, sorry @hms, would you mind rebasing this branch on the last |
|
Will do my best to get it done in the 48 hours. Have some serous family stuff up in the air at the moment. |
|
Oh no! I'm so sorry to hear that 😔 Please don't worry about this; there's absolutely no rush or anything. Wishing you the best. |
This PR updates SolidQueue::Pool from the deprecated Concurrent::Future to the more "promising" (sorry) Concurrent::Promises API. Rational: The Promises based API is documented as preferred over the Future API. Concurrent::Promises are more performant and deadlock resistant -- Good Things(tm) for SolidQueue. Given Concurrent::Promises where released 2018, there is little "new" or "not battle tested" risk with this change.
|
@rosa rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates SolidQueue::Pool from the deprecated Concurrent::Future to the more "promising" (sorry) Concurrent::Promises API.
Rational:
The Promises based API is documented as preferred over the Future API. Concurrent::Promises are more performant and deadlock resistant -- Good Things(tm) for SolidQueue.
Given Concurrent::Promises where released 2018, there is little "new" or "not battle tested" risk with this change.