-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finished_at_start/end job filters #111
Conversation
Hi @rosa! Don't mean to bother you but in case you missed this this PR is ready for review :) |
@Xeitor thanks for letting me know, I'll try to review soon! |
Hi @rosa, hope you are doing great Sorry to bother you, wanted to know if you were able to take a look at the PR :) |
Hey @Xeitor, so sorry about this huge delay! I haven't had time to focus on Mission Control lately, but it's definitely in the plans for October, I need to spend a week or so just working on all pending PRs and missing features 😳 |
for sure no problem |
Hey @Xeitor, I'm finally back with Mission Control. Are you still interested in working on this one? I'd understand if not, given how long it's been, so sorry about that! If you're no longer interested, I'm happy to take it from here. |
hi @rosa, glad to have you back. For sure, no worries, I 'll take a look at the comments in the next days |
Co-authored-by: Rosa Gutierrez <[email protected]>
Co-authored-by: Rosa Gutierrez <[email protected]>
Co-authored-by: Rosa Gutierrez <[email protected]>
Hey @Xeitor, I think this is ready but would you mind adding one test or two to make sure this doesn't break in the future? |
Wait, never mind, you've already spent too long on this, so no worries at all. I'll get this merged and will add the tests myself 🙏 |
Thanks, @Xeitor! I think other filters have been implemented in a separate PR, so don't worry about that. |
great! feel free to reach out if you need something |
Changelog
Issue: #30
PD: I'll split the different filters in different PRs for easier review