Pass CI for [email protected]
#415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to rails/rails#53962 As of [abdbff4][], calls to [Hash#to_query][] with `nil` values will omit the joining `=` character. This change resolves [CI failures][] for Rails past `[email protected]` like: ``` 1) Failure: BaseTest#test_collection_path_with_parameters [test/cases/base_test.rb:779]: Expected: "/people.json?gender=" Actual: "/people.json?gender" 2) Failure: SingletonTest#test_singleton_path_with_parameters [test/singleton_test.rb:44]: Expected: "/weather.json?degrees=" Actual: "/weather.json?degrees" ``` [abdbff5]: rails/rails@abdbff5 [Hash#to_query]: https://edgeapi.rubyonrails.org/classes/Hash.html#method-i-to_query [CI failures]: https://github.com/rails/activeresource/actions/runs/12606260018/job/35136128961?pr=411#step:4:17
seanpdoyle
commented
Jan 5, 2025
| @@ -776,7 +776,11 @@ def test_collection_path | |||
| def test_collection_path_with_parameters | |||
| assert_equal "/people.json?gender=male", Person.collection_path(gender: "male") | |||
| assert_equal "/people.json?gender=false", Person.collection_path(gender: false) | |||
| assert_equal "/people.json?gender=", Person.collection_path(gender: nil) | |||
| if ActiveSupport::VERSION::MAJOR < 8 || ActiveSupport::VERSION::MINOR < 1 | |||
There was a problem hiding this comment.
As an alternative to version checking, I also considered an explicit { key: nil }.to_query == "key", but felt that was too verbose and harder to grep for in the future when these branches are no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to rails/rails#53962
As of [abdbff4][], calls to Hash#to_query with
nilvalues will omit the joining=character.This change resolves CI failures for Rails past
[email protected]like: