Reset ActiveResource::HttpMock in test teardown
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `ActiveResource::HttpMock.respond_to` without arguments reset the mock, clearing previously defined request-response pairs. Invocations with a final positional argument of `false` **do not clear** previously defined request-response mocks. This behavior can be useful for tests that require a sequence of Http mock definitions. Regardless of the style of invocation, the collection of mocks should be reset between individual tests, so that mock state does not leak into subsequent test cases, which has the potential to cause unpredictable behavior and flaky tests. This change defines an `ActiveSupport.on_load` hook to execute for `ActiveSupport::TestCase` instances. The hook defines a [teardown][] block to invoke `ActiveResource::HttpMock#reset!` between test cases. [teardown]: https://edgeapi.rubyonrails.org/classes/ActiveSupport/Testing/SetupAndTeardown/ClassMethods.html#method-i-teardown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
ActiveResource::HttpMock.respond_towithout arguments reset the mock, clearing previously defined request-response pairs.Invocations with a final positional argument of
falsedo not clear previously defined request-response mocks. This behavior can be useful for tests that require a sequence of Http mock definitions.Regardless of the style of invocation, the collection of mocks should be reset between individual tests, so that mock state does not leak into subsequent test cases, which has the potential to cause unpredictable behavior and flaky tests.
This change defines an
ActiveSupport.on_loadhook to execute forActiveSupport::TestCaseinstances. The hook defines a teardown block to invokeActiveResource::HttpMock#reset!between test cases.