Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed task handling when cancelled #3304

Merged
merged 3 commits into from
Jan 28, 2025
Merged

fixed task handling when cancelled #3304

merged 3 commits into from
Jan 28, 2025

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Jan 27, 2025

when task is cancelled it shouldn't be handled within the Popen._check_running method

(*) revert back this change 2e6f186

Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, thanks!

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.28%. Comparing base (9aa29b1) to head (c52cadb).
Report is 4 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/agent/executing/popen.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3304      +/-   ##
==========================================
+ Coverage   43.27%   43.28%   +0.01%     
==========================================
  Files          97       97              
  Lines       11459    11460       +1     
==========================================
+ Hits         4959     4961       +2     
+ Misses       6500     6499       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov mtitov merged commit 4e30146 into devel Jan 28, 2025
29 of 30 checks passed
@mtitov mtitov deleted the fix/cancellation branch January 28, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants