Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger dump via command #3295

Merged
merged 11 commits into from
Jan 24, 2025
Merged

trigger dump via command #3295

merged 11 commits into from
Jan 24, 2025

Conversation

andre-merzky
Copy link
Member

This PR adds support for

radical-pilot-command rp.session.thinkie.merzky.020078.0069 dump name=foo

which will result in

$ ls rp.session.thinkie.merzky.020078.0069/*json
rp.session.thinkie.merzky.020078.0069/pmgr.0000.foo.json
rp.session.thinkie.merzky.020078.0069/rp.session.thinkie.merzky.020078.0069.reg.foo.json  rp.session.thinkie.merzky.020078.0069/rp.session.thinkie.merzky.020078.0069.reg.init.json  rp.session.thinkie.merzky.020078.0069/tmgr.0000.foo.json

If name=foo is ommited, the normal registry and manager dumps occur, and the session then can be used for analytics.
Note that the first argument must point to a client session sandbox - the <SID>.reg.init.json is used to extract the ZMQ endpoints of the CONTROL pubsub over which the request message is sent.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 43.36%. Comparing base (49dce8f) to head (987fbaf).
Report is 12 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/session.py 17.64% 14 Missing ⚠️
src/radical/pilot/task_manager.py 12.50% 7 Missing ⚠️
src/radical/pilot/pilot_manager.py 16.66% 5 Missing ⚠️
src/radical/pilot/utils/prof_utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3295      +/-   ##
==========================================
- Coverage   43.40%   43.36%   -0.05%     
==========================================
  Files          97       97              
  Lines       11357    11381      +24     
==========================================
+ Hits         4930     4935       +5     
- Misses       6427     6446      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov mtitov linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@andre-merzky andre-merzky merged commit c363510 into devel Jan 24, 2025
30 checks passed
@andre-merzky andre-merzky deleted the feature/command_msg branch January 24, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control command from the outside of the current run
2 participants