-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This should follow the discussion on #114 (comment) |
Though this should be fine to land as-is now, we can improve it later. |
The package.json file uses 2 space indentation. |
The package.json is mostly updated through npm, which always rewrites it after a We may follow the suggestion on the editorconfig website: # Matches the exact files either package.json or .travis.yml
[{package.json,.travis.yml}]
indent_style = space
indent_size = 2 |
I went ahead and added rules for *.json and *.yml files. Let me know if I should add anything else. |
trim_trailing_whitespace = true | ||
insert_final_newline = true | ||
|
||
[*.{json,yml}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be specific to the affected files, [{package.json,.travis.yml}]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can possibly see that for *.json, but shouldn't yml always be two space indented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that's in the spec: http://yaml.org/spec/current.html#id2519916 - apparently the amount doesn't matter, but sticking with 2
makes sense.
Let's not let the larger discussion hold this up. @leobalter is there anything stopping this from being merged? |
It LGTM. |
Adds an editorconfig file to establish minimal standards for edits to any project file