Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PRODUCT decomposition #1542

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christopherkang
Copy link

I have performed a quick implementation of the PRODUCT function using the implementation suggested in https://arxiv.org/pdf/2007.07391 (page 69).

This addresses issue #485.

Some notes:

  • This achieves the desired complexity and relies upon the AND bloq. It is important to use the AND bloq because the AND.adjoint natively allows us to uncompute without additional Toffoli complexity (by using the strategies from Gidney)
  • It also includes a brute force test checking all implementations with input sizes ranging from 1-3 bits.
  • My code as of now is not fully commented + notated --- I would appreciate feedback on making it better!

Copy link

google-cla bot commented Feb 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NoureldinYosri NoureldinYosri self-requested a review February 4, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant