Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some documentation for proto serialization #1530

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Some documentation for proto serialization #1530

wants to merge 3 commits into from

Conversation

mpharrigan
Copy link
Collaborator

  • Consistent naming: switched to bloq_id from a mixture of bloq_id and bloq_idx. bloq_id is used in the proto; and makes more sense since it's an identifier and not an index
  • Add a couple details to the docstrings and comments

@mpharrigan
Copy link
Collaborator Author

@tanujkhattar can you ptal

@mpharrigan mpharrigan enabled auto-merge (squash) February 3, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpharrigan @tanujkhattar