Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in ECAdd bloq #1489

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix bugs in ECAdd bloq #1489

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
af46d88
fix som ebugs
fpapa250 Nov 4, 2024
1755ef4
remove one dirty statement
fpapa250 Nov 4, 2024
b97ac02
Merge branch 'main' into ecc-fix-add
fpapa250 Nov 5, 2024
1ddc3ee
Correct the rest of the ECAdd bugs from the paper
fpapa250 Nov 7, 2024
9a83d8e
Fix symbolic cvs for step 5
fpapa250 Nov 7, 2024
c5668d5
Merge branch 'main' into ecc-fix-add
fpapa250 Nov 27, 2024
2f52006
Merge branch 'main' into ecc-fix-add
fpapa250 Nov 27, 2024
6da2b0e
Fix final test with Equals.controlled working
fpapa250 Nov 27, 2024
64e3989
Update qualtran/bloqs/factoring/ecc/ec_add.py
fpapa250 Nov 29, 2024
15fa7c5
formatting
fpapa250 Nov 29, 2024
3694769
Merge branch 'main' into ecc-fix-add
fpapa250 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into ecc-fix-add
  • Loading branch information
@fpapa250
fpapa250 committed Feb 4, 2025
commit 3694769d01ff7bef05e29a288747ee2970efe08c

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.