-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine low level moisture with a cloud mask #3022
base: main
Are you sure you want to change the base?
Conversation
Change the approach for ESSL colorisation. Remove the dedicated class and instead define a colourmap to be used with the colorize enhancement. Fix the ratio to be the right way around. Fixes and closes 3020.
Combine ESSL colorized low level moisture with a cloud mask. Work in progress.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
==========================================
- Coverage 96.10% 96.09% -0.01%
==========================================
Files 377 375 -2
Lines 55163 55103 -60
==========================================
- Hits 53012 52952 -60
Misses 2151 2151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12673414590Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
If I don't give its own enhancement to the masked colorised llm, either the masked or the unmasked version doesn't find its enhancement.
Great idea! a couple of questions:
|
Change standard_name back to name in the enhancement, or satpy won't find the correct enhancement and won't use it.
fixing one merge conflict
The cloud mask claims a sharp edge there between cloud-free and cloudy:
The cloud mask stops.
Maybe a resampling artefact. Redoing the resampling with gradient search, the result looks different, but still has artefacts: Oh, gradient search is of course not great for a cloud mask. |
Nice imagery! do you have the date and time for this slot? |
2024-12-17 12:10 |
Combine ESSL colorized low level moisture with a cloud mask.
Needs Re-implement essl_colorized_low_level_moisture using colorize #3020 to be merged first.
Preferably, Clip negative FCI radiances #3013 should be merged first, because that PR includes a lot of work on the behave tests that I would like to leverage on before creating a test.
Preferably, we should fix Cannot load ABI or FCI L1 datasets from Scene combining L1 and L2 #1913 first or a low level moisture defined by wavelength cannot be loaded when level 2 data are present.
Closes #xxxx
Tests added
Fully documented
Example for eurol: