Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine low level moisture with a cloud mask #3022

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gerritholl
Copy link
Member

@gerritholl gerritholl commented Dec 18, 2024

Combine ESSL colorized low level moisture with a cloud mask.

Example for eurol:

MTG-I1-fci-eurol-colorized_low_level_moisture_with_vis06-20241217120000-20241217121000

Change the approach for ESSL colorisation.  Remove the dedicated class
and instead define a colourmap to be used with the colorize enhancement.
Fix the ratio to be the right way around.

Fixes and closes 3020.
Combine ESSL colorized low level moisture with a cloud mask.

Work in progress.
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (5984c29) to head (b829d96).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
- Coverage   96.10%   96.09%   -0.01%     
==========================================
  Files         377      375       -2     
  Lines       55163    55103      -60     
==========================================
- Hits        53012    52952      -60     
  Misses       2151     2151              
Flag Coverage Δ
behaviourtests 3.93% <ø> (-0.02%) ⬇️
unittests 96.19% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12673414590

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 96.202%

Totals Coverage Status
Change from base Build 12299617024: -0.004%
Covered Lines: 53194
Relevant Lines: 55294

💛 - Coveralls

@gerritholl gerritholl marked this pull request as ready for review January 7, 2025 16:20
@mraspaud
Copy link
Member

mraspaud commented Jan 8, 2025

Great idea! a couple of questions:

  • what’s happening over the baltic sea?
  • what’s happening above the arctic circle? looks like the colors are still there, but much darker. Is it the night side, and the sharp edge of the colorised part is the terminator?

Change standard_name back to name in the enhancement, or satpy won't
find the correct enhancement and won't use it.
@gerritholl
Copy link
Member Author

gerritholl commented Jan 8, 2025

* what’s happening over the baltic sea?

The cloud mask claims a sharp edge there between cloud-free and cloudy:

MTI1-FCI-eurol-cloud_state-20241217120000-20241217121000

* what’s happening above the arctic circle?

The cloud mask stops.

looks like the colors are still there, but much darker. Is it the night side, and the sharp edge of the colorised part is the terminator?

Maybe a resampling artefact. Redoing the resampling with gradient search, the result looks different, but still has artefacts:

MTG-I1-fci-eurol-colorized_low_level_moisture_with_vis06-20241217120000-20241217121000

Oh, gradient search is of course not great for a cloud mask.

@gerritholl
Copy link
Member Author

Resampling with nearest neighbour again, but with a larger radius of influence, the result looks better:

MTG-I1-fci-eurol-colorized_low_level_moisture_with_vis06-20241217120000-20241217121000

@gerritholl
Copy link
Member Author

With the modifier effective_solar_pathlength_corrected:

MTG-I1-fci-eurol-colorized_low_level_moisture_with_vis06-20241217120000-20241217121000

Version filled with IR 105 instead (using night_ir105 even during the day):

MTG-I1-fci-eurol-colorized_low_level_moisture_with_ir105-20241217120000-20241217121000

@mraspaud
Copy link
Member

mraspaud commented Jan 8, 2025

Nice imagery! do you have the date and time for this slot?

@gerritholl
Copy link
Member Author

do you have the date and time for this slot?

2024-12-17 12:10

@gerritholl
Copy link
Member Author

Case from today (2025-01-80 15:30), with the night part blended out using the DayNightCompositor:

202501081530-ninjo-new-low-level-moisture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load ABI or FCI L1 datasets from Scene combining L1 and L2
3 participants