-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ESSL colorisation approach #3021
base: main
Are you sure you want to change the base?
Conversation
Change the approach for ESSL colorisation. Remove the dedicated class and instead define a colourmap to be used with the colorize enhancement. Fix the ratio to be the right way around. Fixes and closes 3020.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3021 +/- ##
==========================================
- Coverage 96.10% 96.08% -0.02%
==========================================
Files 377 375 -2
Lines 55163 55103 -60
==========================================
- Hits 53012 52944 -68
- Misses 2151 2159 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12651965186Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
bab99f9
to
982a31c
Compare
Thanks for the PR! Can we have a before/after image comparison? |
Change standard_name back to name in the enhancement, or satpy won't find the correct enhancement and won't use it.
Change the approach for ESSL colorisation. Remove the dedicated class and instead define a colourmap to be used with the colorize enhancement. Fix the ratio to be the right way around.
Fixes and closes 3020.