Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ESSL colorisation approach #3021

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gerritholl
Copy link
Member

Change the approach for ESSL colorisation. Remove the dedicated class and instead define a colourmap to be used with the colorize enhancement. Fix the ratio to be the right way around.

Fixes and closes 3020.

Change the approach for ESSL colorisation.  Remove the dedicated class
and instead define a colourmap to be used with the colorize enhancement.
Fix the ratio to be the right way around.

Fixes and closes 3020.
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (5984c29) to head (b3e3b31).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
- Coverage   96.10%   96.08%   -0.02%     
==========================================
  Files         377      375       -2     
  Lines       55163    55103      -60     
==========================================
- Hits        53012    52944      -68     
- Misses       2151     2159       +8     
Flag Coverage Δ
behaviourtests 3.93% <ø> (-0.02%) ⬇️
unittests 96.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12651965186

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 96.188%

Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.16%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
Totals Coverage Status
Change from base Build 12299617024: -0.02%
Covered Lines: 53186
Relevant Lines: 55294

💛 - Coveralls

@mraspaud mraspaud assigned mraspaud and gerritholl and unassigned mraspaud Jan 8, 2025
@mraspaud
Copy link
Member

mraspaud commented Jan 8, 2025

Thanks for the PR! Can we have a before/after image comparison?

Change standard_name back to name in the enhancement, or satpy won't
find the correct enhancement and won't use it.
@gerritholl
Copy link
Member Author

Before :

202310010850-MTG-I1-fci-eurol-essl_colorized_low_level_moisture

After:

202310010850-MTG-I1-fci-eurol-essl_colorized_low_level_moisture-after

We see a difference only in the noise part at night, probably because the ratio is defined the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement essl_colorized_low_level_moisture using colorize
3 participants