fix: li missing platform name

[BENR0]

This fixes the DataArrays returned by the li reader missing the platform_name attribute.

• Closes #xxxx
• Tests added
• Fully documented
• Add your name to AUTHORS.md if not there already

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (0589f61) to head (c1c7357).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2993   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         377      377           
  Lines       55162    55192   +30     
=======================================
+ Hits        53012    53042   +30     
  Misses       2150     2150           

Flag	Coverage Δ
behaviourtests	3.94% <0.00%> (-0.01%)	⬇️
unittests	96.19% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coveralls]

Pull Request Test Coverage Report for Build 11951131663

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 96.193%

---

Totals
Change from base Build 11936881763:	0.0%
Covered Lines:	53241
Relevant Lines:	55348

---

💛 - Coveralls

[ameraner]

Thanks @BENR0 , I've noticed this as well recently. Could we take the platform info from the filename and use the mapping as done for FCI here?

satpy/satpy/readers/fci_l1c_nc.py

Lines 205 to 209 in 1a7a342

	_platform_name_translate = {
	"MTI1": "MTG-I1",
	"MTI2": "MTG-I2",
	"MTI3": "MTG-I3",
	"MTI4": "MTG-I4"}

Although the question of the platform name and the operational renaming to e.g. MET-12 is very valid...

[BENR0]

@ameraner Maybe we just wait till it is renamed to fix it? Shouldn't be that long till then I guess? ;-)
And yes I think a mapping would make it more future proof.

[ameraner]

Yeah, should only be a couple of weeks or so :) As you prefer, I'm ok also with merging this and update again later.
Then I would use a mapping/naming similar to what is used for SEVIRI, like Meteosat-XX

satpy/satpy/readers/seviri_l1b_native.py

Line 317 in d22d2b6

self.mda["platform_name"] = "Meteosat-" + SATNUM[self.platform_id]

[BENR0]

@ameraner Do you know if the name will eventually also be changed on https://space.oscar.wmo.int/satellites/ from MTG-I1 to Meteosat-12?

[ameraner]

I assume so, as the MSG satellites are also listed as Meteosat-XX.

[BENR0]

@ameraner @mraspaud I changed the platform name for FCI/LI according to the renaming after MTG went operational.

[ameraner]

Thanks! The changes look good to me, however it seems that both the FCI and LI tests need to be updated..

[BENR0]

@ameraner good point. didn't check those. Fixed the tests. Not very nice though, a lot of repitition. Maybe should be refactored at some point to convert the filehandler which is used quite often into a fixture.

[ameraner]

LGTM, thanks!

[gerritholl]

Since you're at it anyway, would you mind expanding this to FCI L2 and fix #3026 in the same go? It fits thematically with this PR. Or we can fix it in a new PR.

[gerritholl]

I would move this to fci_base.py so it can also be used by fci_l2_nc.py (see #3026). Or even an mtg_base.py to be used by both FCI and LI.

[gerritholl]

Since we're now using this across modules, should we remove the _ prefix?