Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: fix contrast of footer highlight #162

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 3, 2023

@hugovk hugovk added the bug label Dec 3, 2023
@hugovk hugovk merged commit 2c4de5a into python:main Dec 4, 2023
9 checks passed
@hugovk hugovk deleted the fix-dark-mode-footer-highlight-contrast branch December 4, 2023 18:11
@ferdnyc
Copy link

ferdnyc commented Jan 26, 2024

Hah! I was just coming here to get started on a similar pull request.

Unfortunately, while this is merged, it still isn't deployed on docs.python.org. Those docs still show the unreadable yellow background, in the dark theme.

Is there a procedure for getting the live docs to pull in theme updates?

@hugovk
Copy link
Member Author

hugovk commented Jan 26, 2024

Hah! I was just coming here to get started on a similar pull request.

Thank you!

Is there a procedure for getting the live docs to pull in theme updates?

Yes, the procedure is:

We have a few thing pending release, I'll make one later today or this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode: highlighted footnote unreadable
3 participants