This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this branch instead of #151 mostly due to working out of my fork and not using more CI than needed.
I've responded to the comments and moved to a much simpler interface for RequestData that is mostly a Content-Type attached to a byte iterator factory.
Currently Request and RequestData aren't connected in any way, I'm not sure if they need to be if they mostly live within the scope of
Session.request()
anyways. We never present a Request to a user with a body on it.Also another note here is that our interface now only presents
URL
andHeaders
, even when callingrequest.headers = {}
you'll receive aHeaders
object fromx = request.headers