Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call loop.shutdown_asyncgens before closing the event loop #1034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

provinzkraut
Copy link

#222 was closed, mentioning the issues being resolved in the yet-to-be-done #235, running with -W error in Python 3.13, currently fails when there are unclosed async generators.

This is a minimally invasive fix, without attempting to behave like asyncio.run on shutdown in all other scenarios.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (623ab74) to head (f2e620b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
+ Coverage   91.10%   91.13%   +0.03%     
==========================================
  Files           2        2              
  Lines         562      564       +2     
  Branches       74       74              
==========================================
+ Hits          512      514       +2     
  Misses         30       30              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid patch, thank you!

Can you please add an entry to docs/reference/changelog.rst as well, where you briefly explain the change and link to this PR? We can create another patch release for this. Just set the date to UNRELEASED and we'll handle the rest.

@seifertm seifertm added this to the v0.25 milestone Jan 7, 2025
@provinzkraut
Copy link
Author

@seifertm Added a comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants