Import zipfile to avoid problem with late import (#428)

- fixes #427
pytest-dev · Sep 9, 2018 · eeb80f6 · eeb80f6
1 parent 2638de2
commit eeb80f6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/pyfakefs/fake_filesystem_unittest.py b/pyfakefs/fake_filesystem_unittest.py
@@ -41,6 +41,7 @@
 import sys
 import tempfile
 import unittest
+import zipfile  # import here to make sure it gets correctly stubbed, see #427
 
 from pyfakefs.deprecator import Deprecator
 

diff --git a/pyfakefs/tests/fake_filesystem_unittest_test.py b/pyfakefs/tests/fake_filesystem_unittest_test.py
@@ -378,5 +378,19 @@ def test_set_up_pyfakefs(self):
         self.assertIsInstance(self.fs, fake_filesystem.FakeFilesystem)
 
 
+class TestShutilWithZipfile(fake_filesystem_unittest.TestCase):
+    """Regression test for #427."""
+    def setUp(self):
+        self.setUpPyfakefs()
+        self.fs.create_file('foo/bar')
+
+    def test_a(self):
+        shutil.make_archive('archive', 'zip', root_dir='foo')
+
+    def test_b(self):
+        # used to fail because 'bar' could not be found
+        shutil.make_archive('archive', 'zip', root_dir='foo')
+
+
 if __name__ == "__main__":
     unittest.main()