Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow arbitrary env keys eg valueFrom #41

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lizthegrey
Copy link

No description provided.

@pyroscope-io pyroscope-io deleted a comment from CLAassistant Dec 24, 2021
@lizthegrey
Copy link
Author

Testing this against my own vendored copy, will report back...

@kolesnikovae
Copy link
Member

Thank you for the contribution @lizthegrey!

Yeah, I think we should keep the current behavior of env for backward compatibility. We can introduce an additional variable, although it will be difficult to combine them.

Alternatively, since the main scenario for this is using secrets, we could use the envFrom directive:

{{- if .Values.envFromSecret }}
envFrom:
- secretRef:
    name: {{ .Values.envFromSecret }}
{{- end }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants