Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Tortured Phase Contrast Department #658

Merged
merged 6 commits into from
May 24, 2024
Merged

The Tortured Phase Contrast Department #658

merged 6 commits into from
May 24, 2024

Conversation

smribet
Copy link
Collaborator

@smribet smribet commented May 24, 2024

A few hot fixes

Copy link
Member

@gvarnavi gvarnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!
We might as-well merge this in dev since one of the fixes addresses #657.

@@ -30,7 +30,7 @@
"ncempy >= 1.8.1",
"matplotlib >= 3.2.2",
"scikit-image >= 0.17.2",
"scikit-learn >= 0.23.2",
"scikit-learn >= 0.23.2, < 1.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for now, but let's loop back and relax this once they've figured out their regression

@gvarnavi gvarnavi merged commit a49e030 into dev May 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants