Added realspace mask for radial statistics in polardatacube #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Steve - these changes were included in another branch of Colin's and
he expressed a preference to wait for that code to be merged first and then
drop this PR. Either way is good, this update is ready to go imo. @colin do
you still have a preference?
…On Fri, Mar 8, 2024, 4:54 PM Steve Zeltmann ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
Reply to this email directly, view it on GitHub
<#537 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQYYNOP3INPKXAZBCM4RJTYXIXQJAVCNFSM6AAAAAA6GFLZO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRVHEYDOMRTG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new argument to calculate_radial_statististics():
mask_realspace = mask,
So new function looks like:
polardata.calculate_radial_statistics(
mask_realspace = mask,
)
Should be fully backward compatible.