Add deposit when buying with fiat #139
Conversation
|
When it's possible to buy with fiat without depositing it before (see your comment in #138), we shouldn't implement it like that. A warning might be ok in that case which could disable the deposit/withdrawal page in the export. |
|
Then you get a warning that you basically can do nothing about. |
|
Good points! |
There was a problem hiding this comment.
Hey @jhoogstraat,
please have a look at my comments. I belive that we should dig deeper into the problem to fully solve it.
| @@ -435,7 +447,7 @@ def _read_coinbase_v2(self, file_path: Path) -> None: | |||
| self._read_coinbase(file_path=file_path) | |||
|
|
|||
| def _read_coinbase_pro(self, file_path: Path) -> None: | |||
| platform = "coinbase_pro" | |||
| platform = "coinbase" | |||
There was a problem hiding this comment.
As discussed in #138, instead of making them the same, we should consider the deposits/withdrawals between them.
| _currency_spot, | ||
| row, | ||
| file_path, | ||
| ) |
There was a problem hiding this comment.
As it's also possible to deposit fiat first and buy later on, we have to check against that and can not merely add a deposit action.
It might be ok to disable tracking of deposit and withdrawals with home fiat which might solve most of the problem.
We can add a config variable for that. and should raise a warning when we adjust the config variable while evaluating the coinbase account statement, which as a buy with fiat.
If it is still bothering we should add a file in parallel which lists all buys to coinbase and initialize there value as 0 (do not add deposit on default). The user can adjust the file so that deposits will be added on the second run.
The format of the could be ini (csv might be a good "normal" format, but editing csv with Excel fucks up the format most of the time which might create a headache for most of the users) and should be saved in the account statements folder.
This adds a deposit operation when buying coins with fiat on coinbase.
Also sets the platform from "coinbase_pro" to "coinbase" to remove issue regarding transfers between the two.
Tracking issue: #138