Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #80

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Improve logging #80

merged 1 commit into from
Oct 13, 2024

Conversation

isker
Copy link
Contributor

@isker isker commented Oct 13, 2024 •
edited
Loading

  • Add debug logging that logs the full ECS responses, which can be used with JSON log formatting to enable developing against the actual behavior of the ECS APIs.
  • Error when the ECS APIs return a non-2xx response. They are not specified to ever do so, but surely we should not be trying to deserialize response bodies to the usual JSON objects in such situations.

SuperQ
SuperQ reviewed Oct 13, 2024
View reviewed changes
ecscollector/collector.go Outdated Show resolved Hide resolved
@isker
Improve logging
6eb4916 
- Add debug logging that logs the full ECS responses, which can be used
  with JSON log formatting to enable developing against the actual
  behavior of the ECS APIs.
- Error when the ECS APIs return a non-2xx response. They are not
  specified to ever do so, but surely we should not be trying to
  deserialize response bodies to the usual JSON objects in such
  situations.

Signed-off-by: Ian Kerins <[email protected]>
SuperQ
SuperQ approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 593ea5f into prometheus-community:main Oct 13, 2024
4 checks passed
@isker isker deleted the improve-logging branch October 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isker @SuperQ