chore!: adopt slog, drop go-kit/log #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @SuperQ |
SuperQ
approved these changes
Oct 15, 2024
|
The lint failure is related to the Go upgrade. I merged the latest repo sync PR so the next sync should bring it up-to-date enough to support Go 1.23. |
|
A rebase should fix the lint issue. |
Signed-off-by: TJ Hoplock <[email protected]>
Signed-off-by: TJ Hoplock <[email protected]>
The bulk of this change set was automated by the following script which is being used to aid in converting the various exporters/projects to use slog: https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434 Signed-off-by: TJ Hoplock <[email protected]>
tjhop
force-pushed
the
chore/adopt-slog
branch
from
0747d32 to
cdb9968
Compare
|
rebased 👍 |
Hmm |
Signed-off-by: TJ Hoplock <[email protected]>
|
Woops, I tested builds after the rebase, didn't test linting or I would've seen that. Should be better now 👍 |
SuperQ
added a commit
that referenced
this pull request
Nov 6, 2024
* [CHANGE] Drop XML statistics v2 support #171 * [CHANGE] Deprecate collection of task stats by default #200 * [CHANGE] Update logging library #212 * [ENHANCEMENT] Add metric `rpz_rewrites` #208 * [BUGFIX] Make log level configurable via command-line flag #182 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Nov 6, 2024
* [CHANGE] Drop XML statistics v2 support #171 * [CHANGE] Deprecate collection of task stats by default #200 * [CHANGE] Update logging library #212 * [ENHANCEMENT] Add metric `rpz_rewrites` #208 * [BUGFIX] Make log level configurable via command-line flag #182 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this change set was automated by the following script which
is being used to aid in converting the various exporters/projects to use
slog:
https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434