Display read receipts next to each message as a row of Avatars for users who have seen that message

[alanpoon]

Fixes #153

1. With tooltip indicating number of seen - mouse over

2. mouse out

• Currently only supports Avatar with username. I need some advice how to put in Avatar with image.
• Implemented max display of 4 avatars
• Currently tooltip seems to be not able customize width and position. @jmbejar

[alanpoon]

[WIP] Will try to change sequencer to follow GenUI's way of creating a list of widgets

[alanpoon]

1. Modified set_avatar_and_get_username function to use &mut Avatar instead of AvatarRef
2. Modified set_avatar_and_get_username function to take in an option of Avatar User profile. Read_receipts do not provide user profile. So the User Profile is gotten from the Sender cache.
3. Added Caching for Avatar that is loaded with Image.

[kevinaboos]

A great start, thanks!

I suggested some minor API changes that will make things clearer and less error-prone. After those changes are made, it should be ready to merge.

[kevinaboos]

• Currently only supports Avatar with username. I need some advice how to put in Avatar with image.

Using the existing Avatar widget should work just fine. The reason you never get any proper Avatar profile info is because you always pass None into the set_avatar_and_get_username() function. If you're able to obtain the Avatar image therein (by grabbing it from the cache), then that function should automatically pick it up.

Alternatively, we can create a separate function (or further modify set_avatar_and_get_username()) to utilize the user profile and avatar caches if the passed-in avatar info is None or not-yet available.

[kevinaboos]

There is SignalToUi for enqueue_avatar_update already, so I don't think I can optimize it further.

Hmm, ok. Yeah, the only potential cause I could think of was a missing call to set the UI Signal, but if that's already there, then there might be a different cause for the delay. What I observed is a 10+ second delay between (1) a log statement that says the avatar/profile was fetched for a given user, and (2) the actual image being refreshed for the avatar.

Another cause of this might be how we cache whether a given event was drawn in the timeline. We might need another variable that tracks the draw status of the read receipts separately from that of the event's content and the event's user profile details.

In any case, we can make this improvement later and merge this in now, since the fundamental functionality appears to be working correctly.

[kevinaboos]

Code looks good! I've tested everything locally and it works well.

However, the UI layout of the AvatarRow is a bit inconsistent for different message types. For example, the Avatars are not all vertically aligned, so it looks a bit weird.
There's also still a lot of wasted space on the right side of the RoomScreen.

I think you could fix both of these layout issues by setting the x-alignment of the AvatarRow to the far right side of its parent view in the room screen, and then using a right-margin of 10 or 20.

The final issue would be that the AvatarRow should be displayed towards the bottom of each message, not towards the top of it. This is particularly noticeable on regular (non-Condensed) messages, like the ones from 8:59am, 10:02am, and 10:10am in this screenshot.

[kevinaboos]

Oh, and also feel free to ignore the positioning of the Message action bar (the small Reply button that pops up when you hover over a message). I am in the process of removing that, so you don't need to reserve any space for it on the right side of the room screen.

[alanpoon]

Code looks good! I've tested everything locally and it works well.

However, the UI layout of the AvatarRow is a bit inconsistent for different message types. For example, the Avatars are not all vertically aligned, so it looks a bit weird. There's also still a lot of wasted space on the right side of the RoomScreen.

I think you could fix both of these layout issues by setting the x-alignment of the AvatarRow to the far right side of its parent view in the room screen, and then using a right-margin of 10 or 20.

The final issue would be that the AvatarRow should be displayed towards the bottom of each message, not towards the top of it. This is particularly noticeable on regular (non-Condensed) messages, like the ones from 8:59am, 10:02am, and 10:10am in this screenshot.

Sped up the avatar loading, and right align the read receipt

[kevinaboos]

Looking good, it's almost there!

It seems like there is a slight issue with the way you defined the new Views that wrap around the ReactionList and AvatarRow. It's causing weird whitespace gaps like this:

and this:

Seems like it's mostly a problem with CondensedMessage, CondensedImageMessage, and SmallStateEvent (more so than regular Message and ImageMessage views, but they might also need adjustment). Make sure you try it out with various different widths of the RoomScreen (which is easiest to do by making the RoomsList wider).

In general, the AvatarRow should go at the very bottom right of an event view, and the Reaction list should go directly beneath the content of the event (like it was previously, before this PR).

I made a small commit that adjusted some things.

[kevinaboos]

Fanstastic work, thanks so much! Can confirm that everything is working well.