feat: support repeatable links #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-mp
force-pushed
the
dani/repeatable-links
branch
from
b439e7e to
2c63793
Compare
xrutayisire
reviewed
Nov 27, 2024
src/lib/buildFieldProperties.ts
Outdated
| @@ -164,13 +165,19 @@ function buildFieldProperty( | |||
| } | |||
|
|
|||
| case "media": { | |||
| code = addLine(`${name}: prismic.LinkToMediaField;`, code); | |||
| code = addLine( | |||
| `${name}: prismic.LinkToMediaField${repeatableSuffix};`, | |||
There was a problem hiding this comment.
❓ Are we supporting this?
dani-mp
force-pushed
the
dani/repeatable-links
branch
from
e5c592f to
ff57bc4
Compare
lihbr
approved these changes
Nov 28, 2024
src/lib/buildFieldProperties.ts
Outdated
| break; | ||
| } | ||
|
|
||
| default: { | ||
| code = addLine(`${name}: prismic.LinkField;`, code); | ||
| const type = args.field.config?.repeat | ||
| ? "prismic.Repeatable<LinkField>" |
There was a problem hiding this comment.
Suggested change
| ? "prismic.Repeatable<LinkField>" | |
| ? "prismic.Repeatable<prismic.LinkField>" |
dani-mp
force-pushed
the
dani/repeatable-links
branch
from
7dff467 to
467edf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://linear.app/prismic/issue/DT-2426/aauser-in-slice-machine-when-i-create-a-new-link-with-repeat-property
Description
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩