-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow inline ControlGroup examples to reflow #898
Conversation
|
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just minor feedback.
This reverts commit 7ed87de.
Summary
Updates the inline
CheckboxGroup
andRadioGroup
examples to reflow on narrow viewports.There's quite a large row gap between lines. This could be solved by adding
style={{ rowGap: 'var(--base-size-8)' }}
to theStack
used in the example. Let me know if that would be preferred.Supporting resources (related issues, external links, etc):
Screenshots:
Having to add an inline style to the example isn't ideal, but without it the rowGap is way too big