Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline ControlGroup examples to reflow #898

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

joshfarrant
Copy link
Contributor

@joshfarrant joshfarrant commented Jan 21, 2025

Summary

Updates the inline CheckboxGroup and RadioGroup examples to reflow on narrow viewports.

There's quite a large row gap between lines. This could be solved by adding style={{ rowGap: 'var(--base-size-8)' }} to the Stack used in the example. Let me know if that would be preferred.

Supporting resources (related issues, external links, etc):

Screenshots:

Before After

image

image

Having to add an inline style to the example isn't ideal, but without it the rowGap is way too big

image

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: cff4ee8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 21, 2025

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Jan 21, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@joshfarrant joshfarrant marked this pull request as ready for review January 21, 2025 17:41
@joshfarrant joshfarrant requested a review from rezrah January 21, 2025 17:41
@joshfarrant joshfarrant changed the title wrap inline ControlGroup examples Allow inline ControlGroup examples to reflow Jan 22, 2025
Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just minor feedback.

This reverts commit 7ed87de.
@joshfarrant joshfarrant merged commit e6dd060 into main Jan 22, 2025
17 checks passed
@joshfarrant joshfarrant deleted the joshfarrant/controlgroup-reflow branch January 22, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants