Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SubNav regressions #851

Merged
merged 6 commits into from
Dec 8, 2024
Merged

Fix SubNav regressions #851

merged 6 commits into from
Dec 8, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Dec 6, 2024

Summary

Towards resolving release issues for SubNav

List of notable changes:

  • Fixes z-index bug with global nav in dotcom
  • Fixes mobile menu, which didn't work without aria-current. Restores that behaviour
  • Updated default story to exclude aria-current
  • Hides anchor navigation until it becomes sticky, per Site requirements (see slack thread)

Screenshots:

Please try to provide before and after screenshots or videos

Before After

Screenshot 2024-12-06 at 14 14 19

Screenshot 2024-12-06 at 14 14 28

Before After

Screenshot 2024-12-06 at 14 23 17

Screenshot 2024-12-06 at 14 23 04

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 5eb22d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah merged commit 21b2584 into main Dec 8, 2024
15 of 18 checks passed
@rezrah rezrah deleted the hotfix/subnav-release-patches branch December 8, 2024 09:30
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant